Main thread data #245
Merged
Main thread data #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Sentry.Unity/Integrations/IApplication.cs
bitsandfoxes
reviewed
Jul 6, 2021
bitsandfoxes
reviewed
Jul 6, 2021
bruno-garcia
reviewed
Jul 7, 2021
There was a problem hiding this comment.
Looks great! I have just nit picks.
@bitsandfoxes thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVPIdea is the following: create singleton root game object from
SentryUnityOptions(doesn't matter how many times you callnew()), assign neededMonoBehaviours on it and return them immediately. AccessMonoBehaviourand pass needed data downstream.Additionally, we can cache whatever data we want to acquire on the main thread and reuse it later (ex.
UnityEventProcessor). In the initial commit, I made an example forSystemInfo.operatingSystem(which should be called on the main thread only).The current PR is related to #238, #233