Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Initialization with the game #272

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jul 29, 2021

In preparation for the coming native support.
The aim is to have the Initialization compile with the game to have access to preprocessor directives.

@bitsandfoxes bitsandfoxes added the Feature New feature or request label Jul 29, 2021
@bitsandfoxes bitsandfoxes self-assigned this Jul 29, 2021
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Surprisingly simple change.
One nit but other than that, LGTM

src/Sentry.Unity/UnityLogger.cs Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes merged commit a3e838c into main Aug 2, 2021
@bitsandfoxes bitsandfoxes deleted the feat/init-compile-with-game branch August 2, 2021 15:40
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Compile Initialization with the game ([#272](https://github.com/getsentry/sentry-unity/pull/272))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 9f1f06e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants