Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config window improvements #276

Merged
merged 5 commits into from
Aug 17, 2021
Merged

config window improvements #276

merged 5 commits into from
Aug 17, 2021

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Aug 6, 2021 •
edited
Loading

Fixes: #275

TraceSampleRate:

  • Slider gets stuck
  • Improve tooltip

DSN:

  • string bleeds through when the field is active during tab switching

@bitsandfoxes bitsandfoxes added the Bug Something isn't working label Aug 6, 2021
@bitsandfoxes bitsandfoxes self-assigned this Aug 6, 2021
@bitsandfoxes
Copy link
Contributor Author

Suggestion to make the Traces Sample Rate / Tracing in general relate more to performance monitoring.
Screenshot 2021-08-17 at 11 37 39

@bitsandfoxes bitsandfoxes marked this pull request as ready for review August 17, 2021 12:46
@bitsandfoxes bitsandfoxes changed the title config window jank fixes config window improvements Aug 17, 2021
@bruno-garcia bruno-garcia removed the Bug Something isn't working label Aug 17, 2021
bruno-garcia
bruno-garcia approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏

@bruno-garcia bruno-garcia merged commit da7d065 into main Aug 17, 2021
@bruno-garcia bruno-garcia deleted the fix/config-window-jank branch August 17, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@semuserable semuserable Awaiting requested review from semuserable

Assignees

@bitsandfoxes bitsandfoxes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config Window Jank
2 participants
@bitsandfoxes @bruno-garcia