Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Android Native Support #307

Merged
merged 20 commits into from
Sep 18, 2021
Merged

feat: Android Native Support #307

merged 20 commits into from
Sep 18, 2021

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Sep 11, 2021

Replaces #149
Resolves: #95

submodule on a branch due to: getsentry/sentry-java#1711

Native crash support working

Repro is the sample button ThrowKotlinOnBackground

Note that ThrowKotlin is captured through the C# layer

image

Configure via the editor

image

Some options not yet available via android manifest

Note: if AndroidManifest manipulation doesn't run, we'll stop the app from launching due to:

java.lang.RuntimeException: Unable to get provider io.sentry.android.core.SentryInitProvider: java.lang.IllegalArgumentException: DSN is required. Use empty string to disable SDK

@bruno-garcia bruno-garcia changed the title feat/android native feat: Android Native Support Sep 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2021

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Android Native Support ([#307](https://github.com/getsentry/sentry-unity/pull/307))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against b33f34a

bruno-garcia added a commit to getsentry/sentry-java that referenced this pull request Sep 11, 2021
.gitignore Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia force-pushed the feat/android-native branch 2 times, most recently from f69a009 to a004406 Compare September 17, 2021 19:39
@bruno-garcia bruno-garcia merged commit dd0a059 into main Sep 18, 2021
@bruno-garcia bruno-garcia deleted the feat/android-native branch September 18, 2021 15:50
@bruno-garcia bruno-garcia mentioned this pull request Sep 18, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support native Android crashes
2 participants