Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed unused .asmdefs #316

Merged
merged 2 commits into from
Sep 17, 2021
Merged

fix: Removed unused .asmdefs #316

merged 2 commits into from
Sep 17, 2021

Conversation

bitsandfoxes
Copy link
Contributor

Asmdefs are assets that define how scripts get compiled into DLLs

Except for SentryInitialization.cs we don't have any scripts. So the one for Runtime stays, the rest goes.

Resolves #292

@bitsandfoxes bitsandfoxes added the Feature New feature or request label Sep 17, 2021
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant!

@bruno-garcia bruno-garcia merged commit 7297345 into main Sep 17, 2021
@bruno-garcia bruno-garcia deleted the fix/asmdef-cleanup branch September 17, 2021 14:04
@bruno-garcia bruno-garcia mentioned this pull request Sep 17, 2021
@bruno-garcia
Copy link
Member

Oh, CI was green because it didn't run the build. And it didn't because the file changed doesn't trigger a build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove console warning Assembly Definition .. io.sentry.unity.editor.asmdef' will not be compiled ..
2 participants