c, obj-c and cpp samples #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
commented
Sep 28, 2021
bruno-garcia
commented
Sep 28, 2021
| @@ -170,8 +170,8 @@ MonoBehaviour: | |||
| m_Enabled: 1 | |||
| m_EditorHideFlags: 0 | |||
| m_Script: {fileID: 11500000, guid: 4e29b1a8efbd4b44bb3f3716e73f07ff, type: 3} | |||
| m_Name: | |||
| m_EditorClassIdentifier: | |||
| m_Name: | |||
There was a problem hiding this comment.
Not sure what caused all these white spaces. Tricky to revert the file while keeping the new buttons only.
bitsandfoxes
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both new samples I wasn't able to get a symbolicated stack trace properly. Even though I ran
sentry-clion the directory I configured Unity to create the xcode project and also on the original Unity project (so it can get anything under Temp). In both situations I got:It could symbolicate frames from the SDK itself (since the
.frameworkis copied to the xcode project andsentry-clifound it there) but I didn't find theUnityFramework.framework.Sounds like it's something we need to find out and properly document so users don't get confused.
In any case, here we have 2 more samples: C++ Exceptions and C++ segfault
The Objective-C example requires an additional configuration which requires documenting: #343