feat: android mark sessions as crashed #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sample "Crash in C":
This PR depends on the following changes:
sentry-dotnet
sentry-java
Description before commit:
fbbd75e
(#347) which now Pauses instead of Closes session on OnQuitting:With
ThrowKotlinOnBackground
, sometimes it actually ends up with a graceful shutdown from the .NET point of view:And on restart there's no session open on disk to check if it crashed on the last run.
It is also possible that the .NET layer doesn't shutdown and on restart closes the old session while consulting the Android callback. In that case it works as expected:
Logs for the case where it doesn't work as expected:
The times where the .NET session exits are those where
OnQuitting
gets called:sentry-unity/src/Sentry.Unity/Integrations/UnityApplicationLoggingIntegration.cs
Line 83 in 514cc24