Unity 2019.4.30f1 #350
Merged
Unity 2019.4.30f1 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
commented
Sep 30, 2021
| @@ -31,7 +31,7 @@ jobs: | |||
| unity-installation-path: /Applications/Unity/ | |||
| unity-root: /Applications/Unity/Hub/Editor/ | |||
| unity-path: Unity.app/Contents/MacOS | |||
| - unity-version: 2019.4.21f1 | |||
| - unity-version: 2019.4.30f1 | |||
There was a problem hiding this comment.
Do we really need this here if we have it in the matrix?
There was a problem hiding this comment.
We intend to run CI with multiple Unity versions: 2019, 2020, 2021, and I put it there so I can associate the version changeset with the version number for installing via the hub.
Like .NET does it here.
SimonCropp
reviewed
Sep 30, 2021
| "com.unity.ide.rider": "1.1.4", | ||
| "com.unity.test-framework": "1.1.24", | ||
| "com.unity.ide.rider": "1.2.1", | ||
| "com.unity.ide.visualstudio": "2.0.11", |
There was a problem hiding this comment.
should updating unity also add an extra entry com.unity.ide.visualstudio?
There was a problem hiding this comment.
Fair point! A Unity-Package cleanup: #351 has been on my "want to do" for ages!
SimonCropp
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a changelog entry since this could affect how building/testing and packaging is done.