Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding symbols upload to gradle #408

Merged
merged 34 commits into from
Nov 23, 2021
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Nov 9, 2021

The idea is to upload symbols if the automated symbol-upload is enabled.

  • sentry-cli
    • Add sentry-cli to package-dev
  • Store sentry-cli options
    • Storing the sentry-cli options in it's own scriptable object
    • Creating a sentry.properties on build time so we don't write it to the build.gradle
    • Add additional options and store them in the editor
    • Add to the senty config window
    • Contains opt out flags for symbol upload
    • Auth Token, Org Slug, Project
  • Hook into the Gradle project creation
    • Locate symbols in temp directory on "build/build an run
    • Copy symbols to gradle project on export
    • Set proper permissions to run sentry-cli
    • Append sentry-cli exec task to build.gradle

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shaping up nicely. I know it's a draft but some comments added

src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes marked this pull request as ready for review November 19, 2021 12:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2021

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3538d2a

@bruno-garcia
Copy link
Member

Odd that CI isnt' running

src/Sentry.Unity.Editor/SentryCli.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryCli.cs Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Editor.Tests/DebugSymbolUploadTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Editor.Tests/DebugSymbolUploadTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Editor.Tests/DebugSymbolUploadTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Editor.Tests/SentryCliTests.cs Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia merged commit 4e39ac6 into main Nov 23, 2021
@bruno-garcia bruno-garcia deleted the feat/android-gradle-symbols branch November 23, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants