Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag whether event was created in the UI thread #495

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

SimonCropp
Copy link
Contributor

fixes #62

@getsentry getsentry deleted a comment from github-actions bot Dec 22, 2021
@lucas-zimerman
Copy link
Collaborator

PR looks ok for me.

@bruno-garcia , do you know if it's possible to add the main thread info next to the mechanism? picture for reference
image

So we could have a new item called [main_thread] or [main thread] and set True/False.

Event for reference: https://sentry.io/organizations/sentry-sdks/issues/2866761831/?project=5428557&query=&statsPeriod=90d

@SimonCropp
Copy link
Contributor Author

are the broken builds expected?

@bitsandfoxes
Copy link
Contributor

are the broken builds expected?

No, not really. Main is breaking too without apparent changes.

@SimonCropp SimonCropp merged commit ccf4fa7 into main Dec 23, 2021
@SimonCropp SimonCropp deleted the Tag-whether-event-was-created-in-the-UI-thread branch December 23, 2021 10:59
@bruno-garcia
Copy link
Member

PR looks ok for me.

@bruno-garcia , do you know if it's possible to add the main thread info next to the mechanism? picture for reference

image

So we could have a new item called [main_thread] or [main thread] and set True/False.

Event for reference: https://sentry.io/organizations/sentry-sdks/issues/2866761831/?project=5428557&query=&statsPeriod=90d

Yeah this is something that makes sense to align across all sdks. @philipphofmann I believe had a DACI about this. Or possibly @marandaneto who is away until beginning of January in vacation. Let's figure this out before we release this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag whether event was created in the UI thread
4 participants