Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Escaping sentry-cli path on Windows for gradle #507

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

bitsandfoxes
Copy link
Contributor

Gradle requires paths containing backslashes to be escaped.

@bitsandfoxes bitsandfoxes changed the title fix: Escaping sentry-cli path on Windows fix: Escaping sentry-cli path on Windows for gradle Jan 10, 2022
@bitsandfoxes bitsandfoxes merged commit 3006213 into main Jan 10, 2022
@bitsandfoxes bitsandfoxes deleted the fix/escape-path-on-windows branch January 10, 2022 18:31
@@ -9,6 +9,7 @@
### Fixes

- Fix missing Sentry/Sentry.h ([#504](https://github.com/getsentry/sentry-unity/pull/504))
- Automated Android symbols upload now correctly escapes sentry-cli executable path ([#507](https://github.com/getsentry/sentry-unity/pull/507))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "on Windows"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants