Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Made native samples be platform sensitive #551

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

bitsandfoxes
Copy link
Contributor

Closes #535
The native sample scene buttons now have a top part for the platform-agnostic Requires IL2CPP. They turn inactive if not on IL2CPP.

Followed by a platform-specific section forAndroid and iOS that is easily expandable for i.e. Windows.

nativesample

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b8fc5be

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@bitsandfoxes bitsandfoxes merged commit dbc72c6 into main Feb 7, 2022
@bitsandfoxes bitsandfoxes deleted the feat/native-sample-rework branch February 7, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample should only show buttons applicable the platform where it runs
2 participants