feat: Resolving PBXProject dependency with reflection #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
commented
Feb 28, 2022
bitsandfoxes
commented
Feb 28, 2022
|
Worth linking: Resolves: #588 |
…ntry/sentry-unity into feat/ios-editor-reflection
…ntry/sentry-unity into feat/ios-editor-reflection
bitsandfoxes
changed the title
|
bruno-garcia
reviewed
Mar 2, 2022
bruno-garcia
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Change looks good but I'm afraid of the fact no tests failed, and no tests were added. I expect the call site to require some exception handling when instantiating SentryXcodeProject to deal with the reflection call failing when the iOS Tools for Unity are not installed.
|
Can we get a new release with this fix included? v0.11.0 does not appear to include it. |
|
It's on its way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #588
Until now the SDK depended on Unity's iOS module to be installed. When missing this would not automatically create an error inside the editor but it would lead to issues when iterating over all types (see #525).
To resolve this the
Sentry.Unity.Editor.iOS.dlldeals with its dependency on the Unity iOS module via reflection now.