Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run sentry-dotnet with multiple app instances at the same time (desktop) #643

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Don't run sentry-dotnet with multiple app instances at the same time (desktop) #643

merged 6 commits into from
Mar 22, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Mar 17, 2022 •
edited
Loading

Workaround for #264

@vaind vaind changed the title Don't run multiple instances at the same time (desktop) Don't run sentry-dotnet with multiple app instances at the same time (desktop) Mar 17, 2022
@vaind vaind force-pushed the chore/dotnet-global-mutex branch from 407b93a to cc0f0af Compare March 18, 2022 15:52
bruno-garcia
bruno-garcia approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you @vaind

src/Sentry.Unity/SentryUnity.cs Outdated Show resolved Hide resolved
@vaind vaind force-pushed the chore/dotnet-global-mutex branch from cc0f0af to c4f29b4 Compare March 21, 2022 11:02
bruno-garcia
bruno-garcia approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/Sentry.Unity/SentryUnity.cs Outdated Show resolved Hide resolved
@vaind @bruno-garcia
Update src/Sentry.Unity/SentryUnity.cs
f5a29de 
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@vaind vaind merged commit 2cb40f7 into main Mar 22, 2022
@vaind vaind deleted the chore/dotnet-global-mutex branch March 22, 2022 11:18
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Don't run sentry-dotnet with multiple app instances at the same time (desktop) ([#643](https://github.com/getsentry/sentry-unity/pull/643))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against f5a29de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaind @bruno-garcia