Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed deprecated Sentry json options #709

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Conversation

bitsandfoxes
Copy link
Contributor

Deprecated a long time ago in favor of the scriptable objects.

@bruno-garcia
Copy link
Member

Worth adding a Migration Guide entry and saying: If you're on a version older then X (was it 0.5.0 or whatever ancient) and you're updating it to 0.16.0, you need to first update to a 0.15.0 so your configuration file is migrated through to scriptable object. Right?

@bruno-garcia
Copy link
Member

That can be added to the changelog too btw

@bitsandfoxes
Copy link
Contributor Author

Worth adding a Migration Guide entry and saying

Good point. I'll add it!

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best PR of the week

@bitsandfoxes bitsandfoxes merged commit 6c6a733 into main Apr 29, 2022
@bitsandfoxes bitsandfoxes deleted the chore/remove-json branch April 29, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants