-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux desktop support - breakpad #734
Conversation
f8b9163
to
6061191
Compare
7f69118
to
9ec0907
Compare
.gitignore
Outdated
@@ -24,6 +24,8 @@ package-dev/**/*.pdb | |||
package-dev/**/*.xml | |||
package-dev/**/*.dylib | |||
package-dev/**/*.dSYM | |||
package-dev/**/*.so | |||
package-dev/**/*.full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unity on Android (IIRC) now uses the extension file.sym.so
and I believe @bitsandfoxes is relying on it to run Sentry CLI on the root of a dir and pick all the right files.
Perhaps we could rely on the same bahavior if we can control the extension we use here
package-dev/**/*.full | |
package-dev/**/*.sym.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather ".so.debug" - that's what this answer says is the corresponding filename for "full lib with debug symbols" - https://answers.unity.com/questions/1634142/libil2cppsym-libil2cppsodebug-libunitysymso-what-s-1.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe not, this says something else... https://docs.unity3d.com/2020.3/Documentation/Manual/android-symbols.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- strip all, including exported symbols except those starting with 'sentry_', except for 'sentry__' --> | ||
<Exec WorkingDirectory="$(SentryNativeRoot)" Command="strip -s build/libsentry.so -w -K sentry_[^_]* -o $(SentryLinuxArtifactsDestination)libsentry.so" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swatinem is this the intended way for us to bundle Sentry native?
5b0ccc4
to
05501e0
Compare
05501e0
to
d0bdee7
Compare
closes #694, replaces #699 and #733
This implements the linux crash support using the breakpad handler. Issue samples:
TODOs