Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux desktop support - breakpad #734

Merged
merged 26 commits into from
May 11, 2022
Merged

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented May 9, 2022

@vaind vaind force-pushed the feat/linux-desktop-breakpad branch from f8b9163 to 6061191 Compare May 9, 2022 07:19
@vaind vaind mentioned this pull request May 9, 2022
2 tasks
@vaind vaind force-pushed the feat/linux-desktop-breakpad branch from 7f69118 to 9ec0907 Compare May 9, 2022 15:00
@vaind vaind marked this pull request as ready for review May 9, 2022 16:37
.gitignore Outdated
@@ -24,6 +24,8 @@ package-dev/**/*.pdb
package-dev/**/*.xml
package-dev/**/*.dylib
package-dev/**/*.dSYM
package-dev/**/*.so
package-dev/**/*.full
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unity on Android (IIRC) now uses the extension file.sym.so and I believe @bitsandfoxes is relying on it to run Sentry CLI on the root of a dir and pick all the right files.

Perhaps we could rely on the same bahavior if we can control the extension we use here

Suggested change
package-dev/**/*.full
package-dev/**/*.sym.so

Copy link
Collaborator Author

@vaind vaind May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather ".so.debug" - that's what this answer says is the corresponding filename for "full lib with debug symbols" - https://answers.unity.com/questions/1634142/libil2cppsym-libil2cppsodebug-libunitysymso-what-s-1.html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made an android build and seems like ".dbg.so" is the corresponding extension (i.e. full unstripped lib) Unity uses in Android builds:

image

Comment on lines +232 to +233
<!-- strip all, including exported symbols except those starting with 'sentry_', except for 'sentry__' -->
<Exec WorkingDirectory="$(SentryNativeRoot)" Command="strip -s build/libsentry.so -w -K sentry_[^_]* -o $(SentryLinuxArtifactsDestination)libsentry.so" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swatinem is this the intended way for us to bundle Sentry native?

Directory.Build.targets Outdated Show resolved Hide resolved
src/Sentry.Unity.Native/SentryNativeBridge.cs Outdated Show resolved Hide resolved
@vaind vaind force-pushed the feat/linux-desktop-breakpad branch from 5b0ccc4 to 05501e0 Compare May 9, 2022 20:44
@vaind vaind force-pushed the feat/linux-desktop-breakpad branch from 05501e0 to d0bdee7 Compare May 10, 2022 10:23
@bruno-garcia bruno-garcia merged commit bced34d into main May 11, 2022
@bruno-garcia bruno-garcia deleted the feat/linux-desktop-breakpad branch May 11, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native crash support for Linux
3 participants