-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scene-load transctions based on SceneManagerAPI #768
Conversation
|
|
||
if (GetTestArg() == null) | ||
{ | ||
Debug.Log("SmokeTester.Configure() called but skipped because this is not a SmokeTest (no arg)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A remnant from having the smoke test as part of the sample project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe drop the "unity." prefix? Also, I've noticed the spans are missing names - what's the best practice in other SDKs?
https://sentry.io/organizations/sentry-sdks/performance/sentry-unity:4e44bacb819a4509ac4bb20b2c53d154/?project=5439417&query=transaction.duration%3A%3C15m&statsPeriod=30d&transaction=unity.runtime.startup&unselectedSeries=p100%28%29
Thanks for pointing that out. Initially, I was a bit confused about the naming/description/operation of transactions and spans but the team came up with a scheme I think we can go with for now. |
See #235
This PR uses SceneManagerAPI which is only available in Unity 2020+
Samples:https://sentry.io/organizations/sentry-sdks/performance/sentry-unity:4e44bacb819a4509ac4bb20b2c53d154/?project=5439417&query=transaction.duration%3A%3C15m&statsPeriod=30d&transaction=unity.runtime.startup&unselectedSeries=p100%28%29
The goal is to create a Transaction and a Span for loading scenes. These will be further extended by future auto instrumentation.
![Screenshot 2022-09-28 at 15 10 29](https://user-images.githubusercontent.com/25725783/192824443-97375347-785f-4992-b340-91c8ce116112.png)