fix: Don't access disk on unknown platforms #865
Conversation
| @@ -6,5 +6,6 @@ | |||
| <ProjectReference Include="../../src/sentry-dotnet/src/Sentry/Sentry.csproj" Private="false" /> | |||
| <ProjectReference Include="../../src/Sentry.Unity/Sentry.Unity.csproj" Private="false" /> | |||
| <ProjectReference Include="../../src/Sentry.Unity.Android/Sentry.Unity.Android.csproj" Private="false" /> | |||
| <ProjectReference Include="../Sentry.Unity.Tests/Sentry.Unity.Tests.csproj" /> | |||
There was a problem hiding this comment.
I believe this can cause issues. In .NET IIRC this would return the tests twice. Does it work OK with Unity?
Often in this case we have a test helper class. e.g:
https://github.com/getsentry/sentry-dotnet/tree/main/test/Sentry.Testing
There was a problem hiding this comment.
It does not seem to cause any issues in Unity. We do have those SharedClasses so we could even move it there.
I was so sure that it would be hidden behind the Switch SDK that I didn't even check for |
bitsandfoxes
force-pushed
the
fix/persistent-data-path
branch
from
0fc113d to
4e279aa
Compare
bitsandfoxes
changed the title
| @@ -175,7 +176,10 @@ internal SentryUnityOptions(SentryMonoBehaviour behaviour, IApplication applicat | |||
| ? "editor" | |||
| : "production"; | |||
|
|
|||
| CacheDirectoryPath = application.PersistentDataPath.Trim(); | |||
| if (application.Platform is not RuntimePlatform.Switch) | |||
There was a problem hiding this comment.
The first stab at this was through the UnknownPlatform.cs, for any platform that's not explicitly known to work. If the issue is with creating a directory, I'd suggest moving that code here instead.
An Unknown platform is currently anything that's not iOS, macOS, windows, linux, android, webgl
There was a problem hiding this comment.
Fair point. I think we can use ToSentryOptions from now on for more than just mapping from the ScriptableOptionsto the SentryOptions.
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
bitsandfoxes
changed the title
Apparently,
Application.persistentDataPathnot only returns a path but also creates the directory. This leads to issues on platforms that impose restrictions on fileIO, like the Switch.