-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added a x64 guard to the IL2CPP methods #871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Jul 6, 2022
@@ -108,7 +108,7 @@ public string Platform | |||
|
|||
private Il2CppMethods _il2CppMethods | |||
// Lowest supported version to have all required methods below | |||
#if !ENABLE_IL2CPP || !UNITY_2020_3_OR_NEWER | |||
#if !ENABLE_IL2CPP || !UNITY_2020_3_OR_NEWER || !UNITY_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a 32 bit Unity build to our CI?
vaind
approved these changes
Jul 6, 2022
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Added a x64 guard to the IL2CPP methods ([#871](https://github.com/getsentry/sentry-unity/pull/871)) If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is something off about the way we call native code on
x86
so I'm guarding the IL2CPP feature withUNITY_64
for now:This can easily be reproduced with our own samples and
throw_cpp
.