Fix/proguard setup #885
Merged
Fix/proguard setup #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var gradleNew = Regex.Replace(gradle, @"(\s+consumerProguardFiles [^\r\n]*)", "$1, '" + RuleFileName + "'"); | ||
| if (gradle.Length == gradleNew.Length) | ||
| { | ||
| throw new Exception($"Couldn't add Proguard rule {RuleFileName} to {_gradleScriptPath} - no `consumerProguardFiles` found."); |
There was a problem hiding this comment.
If a user gets here, how can they unblock themselves so they can build the game?
Removing sentry not being an option
There was a problem hiding this comment.
Fixup the file so that this passes. I know that's not perfect, but what's the alternative? Producing a build that breaks at runtime and won't capture errors is IMO worse than disabling Sentry native support for Android
vaind
force-pushed
the
fix/proguard-setup
branch
from
348eae3 to
0a86fe2
Compare
bitsandfoxes
approved these changes
Jul 11, 2022
vaind
force-pushed
the
fix/proguard-setup
branch
from
0a86fe2 to
c2ebd63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #881