Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added screenshot options #912

Merged
merged 13 commits into from
Jul 27, 2022
Merged

feat: Added screenshot options #912

merged 13 commits into from
Jul 27, 2022

Conversation

bitsandfoxes
Copy link
Contributor

Adding options to control screenshot quality back in.
The resolution is controlled via an enum.

  • Full - capture "as is" in full resolution
  • High - capture in half the resolution Default
  • Medium - capture in one-third of the resolution
  • Low - capture in a quarter of the resolution

JPG compression gets controlled via slider separately.

Screenshots

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner July 27, 2022 10:29
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c84c46a

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

src/Sentry.Unity/SentryUnityOptions.cs Show resolved Hide resolved
@bitsandfoxes
Copy link
Contributor Author

bitsandfoxes commented Jul 27, 2022

Tests?

I'll follow up on that with #914.

@bitsandfoxes bitsandfoxes merged commit 37d60f6 into main Jul 27, 2022
@bitsandfoxes bitsandfoxes deleted the feat/screenshot-options branch July 27, 2022 16:14
@oddgames-david
Copy link

Still not the right direction. MaxHeight is the best solution, means you can specify 480 and all screenshots are either 480 or below.

If I specify half resolution to stop 2k screenshots my 480's become unusable at half.

@bitsandfoxes
Copy link
Contributor Author

If I specify half resolution to stop 2k screenshots my 480's become unusable at half.

Fair point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants