Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Made inline methods in Sentry Native Bridge static #932

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

bitsandfoxes
Copy link
Contributor

Resolves #866

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner August 12, 2022 12:24
@bitsandfoxes bitsandfoxes changed the title fix: Removed inline from iOS native bridge fix: Made inline methods in Sentry Native Bridge static Aug 12, 2022
@vaind
Copy link
Collaborator

vaind commented Aug 12, 2022

@bitsandfoxes can you reproduce the mentioned issue locally? If so, maybe try removing the leading underscore, which I guess could be the cause why the symbols are stripped somewhere in the build chain.

@bitsandfoxes
Copy link
Contributor Author

bitsandfoxes commented Aug 16, 2022

@vaind yes, it's reproducible locally. I gave your suggestion a try but the outcome is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting to iOS project failed to build
3 participants