Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed exception from screenshot attachment #937

Merged
merged 5 commits into from
Aug 19, 2022
Merged

fix: Removed exception from screenshot attachment #937

merged 5 commits into from
Aug 19, 2022

Conversation

bitsandfoxes
Copy link
Contributor

Resolves #925

With the .NET SDK filtering empty streams from being added to events, we can now return an empty MemoryStream instead of throwing an exception.

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner August 17, 2022 13:49
vaind
vaind approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, it's possible.

Maybe mention dotnet SDK update in the changelog too? Even though it's a pre-release version.

@bitsandfoxes
Copy link
Contributor Author

Maybe mention dotnet SDK update in the changelog too? Even though it's a pre-release version.

We're going to bump the .NET SDK this week so the changelog is going to be all nice and tidy with the next release.

@bitsandfoxes bitsandfoxes merged commit 29de280 into main Aug 19, 2022
@bitsandfoxes bitsandfoxes deleted the fix/screenshot-memorystream branch August 19, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@vaind vaind vaind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

automatic screenshot feature creates an exception
3 participants
@bitsandfoxes @bruno-garcia @vaind