Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IL2CPP additional arguments #997

Merged
merged 4 commits into from
Sep 30, 2022
Merged

fix: IL2CPP additional arguments #997

merged 4 commits into from
Sep 30, 2022

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Sep 30, 2022

The additional arguments get saved to disk at <project>/ProjectSettings/ProjectSettings.asset.
So we should manage adding and removing the argument.

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner September 30, 2022 15:37
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bitsandfoxes bitsandfoxes merged commit 351cb00 into main Sep 30, 2022
@bitsandfoxes bitsandfoxes deleted the fix/il2cpp-arguments branch September 30, 2022 17:10
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- IL2CPP additional arguments ([#997](https://github.com/getsentry/sentry-unity/pull/997))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 497dd1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants