-
-
Notifications
You must be signed in to change notification settings - Fork 50
Add screenshot capturing for ensure/assert events on Android #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugin-dev/Source/Sentry/Private/Android/Java/SentryBridgeJava.java
|
limbonaut
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mujacica
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic screenshot capturing for ensure and assertion events on Android.
Screenshot capturing on crash events isn’t supported since there’s no way to hook into the crash handler early enough. Unlike on iOS, setting a custom signal handler doesn’t help - by that point it’s already too late to allocate image buffers or perform file I/O.
Note: Currently, screenshot attachments are built from byte buffers rather than file paths since the Android SDK doesn’t provide a way to know when the upload has finished and it’s safe to delete the screenshot file. Clearing attachments at application launch can also be unsafe since assertions are sent roughly at the same time during SDK initialization.
Docs: getsentry/sentry-docs#15107
Closes #567