Skip to content

Conversation

tustanivsky
Copy link
Collaborator

@tustanivsky tustanivsky commented Feb 21, 2025

This PR add a new workflow allowing to build Windows UE Docker image for specified engine version.

Related to #722, #790

#skip-changelog

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need DOCKER_USERNAME and DOCKER_TOKEN added to the repo?


- name: Build Unreal Engine Docker image
run: |
ue4-docker build custom -repo=https://github.com/getsentry/UnrealEngine.git -branch="${{ inputs.ue_version }}" `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider moving the repo also to a variable so we can have "all configs" at the top

@tustanivsky
Copy link
Collaborator Author

We need DOCKER_USERNAME and DOCKER_TOKEN added to the repo?

No, we already have these set up and use them in ci.yml.

@tustanivsky
Copy link
Collaborator Author

tustanivsky commented Feb 24, 2025

Test workflow run revealed a network-related issue which has to be addressed before we can move on with merging this PR. This might be related to the recent large GitHub runner configuration changes as a similar workflow previously passed the prerequisites build stage successfully.

Update: Further investigation revealed that this issue is caused by a ue4-docker bug (adamrehn/ue4-docker#371). For now, we can pull ue4-docker from upstream and build it in our CI instead of installing the latest released (v0.0.115) version via pip.

Update 2: Per my request ue4-docker maintainer released v0.0.116 which contains the fix for this issue so we can return to installing via pip.

@tustanivsky
Copy link
Collaborator Author

getsentry/unreal-docker package has to be made private to comply with the Unreal Engine EULA Restrictions.

We should also remove old package created during testing this CI workflow.

cc @bruno-garcia

Add new docker build workflow to CI ingnore list

Fix workflow name

Fix step name

Fix tag

Fix tag again

Fix secrets in reusable workflow

Try fix secrets again

Uncomment prerequisites stage

Update ue-docker.yml

Fix source image tag

Test

Try exclude DDC

Uncomment prerequisites and source stages

Reduce max concurrent uploads for docker images

Rever docker daemon config

Comment build prerequesites

Update clean-storage-win.ps1

Update clean-storage-win.ps1

Revert sources comment

Comment source

Uncomment

Test

Check for clean up

Fix

More cleanup steps

Test

Test

Test

Test

Uncomment
@tustanivsky tustanivsky merged commit 5ca6687 into main Mar 13, 2025
4 checks passed
@tustanivsky tustanivsky deleted the ci/win-docker branch March 13, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants