-
-
Notifications
You must be signed in to change notification settings - Fork 51
chore: Build Windows UE Docker images in CI #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need DOCKER_USERNAME
and DOCKER_TOKEN
added to the repo?
.github/workflows/ue-docker.yml
Outdated
|
||
- name: Build Unreal Engine Docker image | ||
run: | | ||
ue4-docker build custom -repo=https://github.com/getsentry/UnrealEngine.git -branch="${{ inputs.ue_version }}" ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider moving the repo also to a variable so we can have "all configs" at the top
No, we already have these set up and use them in |
Test workflow run revealed a network-related issue which has to be addressed before we can move on with merging this PR. This might be related to the recent large GitHub runner configuration changes as a similar workflow previously passed the prerequisites build stage successfully. Update: Further investigation revealed that this issue is caused by a Update 2: Per my request |
getsentry/unreal-docker package has to be made private to comply with the Unreal Engine EULA Restrictions. We should also remove old package created during testing this CI workflow. |
Add new docker build workflow to CI ingnore list Fix workflow name Fix step name Fix tag Fix tag again Fix secrets in reusable workflow Try fix secrets again Uncomment prerequisites stage Update ue-docker.yml Fix source image tag Test Try exclude DDC Uncomment prerequisites and source stages Reduce max concurrent uploads for docker images Rever docker daemon config Comment build prerequesites Update clean-storage-win.ps1 Update clean-storage-win.ps1 Revert sources comment Comment source Uncomment Test Check for clean up Fix More cleanup steps Test Test Test Test Uncomment
f2c7440
to
b059c9f
Compare
This PR add a new workflow allowing to build Windows UE Docker image for specified engine version.
Related to #722, #790
#skip-changelog