Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Rate limit details #44875

Open
jeengbe opened this issue Feb 20, 2023 · 8 comments
Open

[Feature Request] Rate limit details #44875

jeengbe opened this issue Feb 20, 2023 · 8 comments

Comments

@jeengbe
Copy link

jeengbe commented Feb 20, 2023

Problem Statement

We have a rate limit configured.

Do projects exceed it? Which ones do? How close are we?

Can also lead to issues like #44833

Solution Brainstorm

More information on the rate limit page.

@getsantry
Copy link
Contributor

getsantry bot commented Feb 20, 2023

Assigning to @getsentry/support for routing, due by Tuesday, February 21st at 09:28 (yyz). ⏲️

@jeengbe
Copy link
Author

jeengbe commented Feb 20, 2023

Also, (slightly out of context) what's the point of the rate limit option? Shouldn't this be covered by spike protection entirely?

@getsantry
Copy link
Contributor

getsantry bot commented Feb 21, 2023

Routing to @getsentry/enterprise for triage, due by Wednesday, February 22nd at 5:00 pm (sfo). ⏲️

@Dhrumil-Sentry
Copy link

@jeengbe Thanks for bringing up this issue. You can find more information about Rate Limiting here

Spike Protection protects your quota from being rapidly depleted. Still, if you see a sustained high volume of events over several days then the Spike protection algorithm will start adjusting since it interprets your event counts as the "new normal" and accordingly spike protection thresholds will start trending higher.

Rate limit is an explicit way for customers to say drop any events if Sentry sees 200+ errors in 1min- Rate Limits are rigid limits and if used aggressively can lead to you missing critical errors and issues

@jeengbe
Copy link
Author

jeengbe commented Feb 22, 2023

Ah I see, thanks @Dhrumil-Sentry! Sort of like a safeguard on top of spike protection.

image

This should say something related with the rate limit instead of "Dropped". I had no idea we drop 60% of errors due to rate limiting.

@Dhrumil-Sentry
Copy link

Dhrumil-Sentry commented Feb 22, 2023

@jeengbe Rate limits are available for Business Plans only and your Org does not have any rate limits, Dropped errors are errors dropped due to invalid data, rate limits, quota limits, or spike protection.

It's likely that your Org is receiving more errors than your monthly quota leading to Sentry dropping those errors

But I agree we should have a better breakdown of dropped errors and I am adding this to our backlog

@jeengbe
Copy link
Author

jeengbe commented Feb 22, 2023

Hi @Dhrumil-Sentry

Then there is probably something wrong with your rate limiting stuff. Not only can I use the UI without restrictions, error events are capped at precisely 2.5k an hour, which corresponds with our set rate limit.

image

Of all things, rate limits are no feature to lock behind a "Business plan", as users who run the Team plan most likely care about cost with rate limits being a crucial last barrier if things go really south.

@getsantry
Copy link
Contributor

getsantry bot commented Jan 31, 2024

Routing to @getsentry/product-owners-stats for triage ⏲️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants