Mobile Replay: Video playback passed the end of the recording #68496
Assignees
Labels
Comments
|
Routing to @getsentry/product-owners-replays for triage ⏲️ |
michellewzhang
added a commit
that referenced
this issue
Apr 17, 2024
This PR fixes 2 bugs related to the video replay timer: <img width="827" alt="SCR-20240416-oqes" src="https://github.com/getsentry/sentry/assets/56095982/3dd16316-ed2b-4d24-a682-f3032ef4742a"> ### 1. If the replay has a gap at the end (e.g. the segment ends but for some reason the duration we get from the SDK extends beyond that), the old behavior was that the replay would just stop. BEFORE: https://github.com/getsentry/sentry/assets/56095982/9f76acc1-d9e6-4a15-a357-0c711da17b4a Notice how the replay stops after 9 seconds. This is because the rest of the replay (the other 4 hours) is junk. The ideal behavior would be to have the replay play until the end, so that it doesn't look weird on the UI. AFTER: https://github.com/getsentry/sentry/assets/56095982/e300e349-d606-4a57-88df-3c49d612a24a Notice how the replay keeps going after 9 seconds (even though technically there isn't any video content to display. It's just showing the previous segment) ### 2. If we seek into the gap at the end of the video, the old behavior of the video replayer was to keep running the timer infinitely. This is because the replayer wanted to run the timer until we can play the next segment (which doesn't exist in this case). BEFORE (video trimmed because you'd be watching paint dry but i seeked to somewhere about 10s from the end): https://github.com/getsentry/sentry/assets/56095982/67ce3e16-2ac5-4432-9bee-defd5fc61a34 Notice how the timer continues running even after the replay "ends". The fix here is to add a notification to the timer to stop at the replay duration (passed in from `replayContext`) when we seek into a gap at the end. This lets the replayer know that we should stop searching for the next (nonexistent) segment. AFTER (video trimmed, same seeking place): https://github.com/getsentry/sentry/assets/56095982/d05b9f49-e4c4-4e49-98d6-49a652b65b9a Video ends at the expected timestamp. Fixes #68496 Also fixes #68509
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Sentry Feedback: JAVASCRIPT-2SED
Video playback passed the end of the recording
video-playback-wont-stop.mov
Part of:
The text was updated successfully, but these errors were encountered: