Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(dev): Upgrade kafka and zookeeper to support Apple M1 (#… #28672

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Sep 20, 2021

…28574)"

This reverts commit b4bfb00.

Originally (see originally reported issue), instead of reverting my change, I landed a fix that only seems to work on Apple M1 (see fix #28724). Nevertheless, It seems that the Intel images would still fail with the same error (see issue #29022) with:

Command [/usr/local/bin/dub path /var/lib/kafka/data writable] FAILED !

Let's revert it and I will try again later.

Fixes #29022

…28574)"

This reverts commit b4bfb00.

It seems to cause the images to restart (see [comment](#28574 (comment))).
@armenzg armenzg closed this Sep 21, 2021
@armenzg armenzg deleted the armenzg/ci/revert-kafka-confluent-upgrade branch September 21, 2021 13:59
@armenzg armenzg restored the armenzg/ci/revert-kafka-confluent-upgrade branch October 4, 2021 18:34
@armenzg armenzg reopened this Oct 4, 2021
@armenzg
Copy link
Member Author

armenzg commented Oct 4, 2021

It seems I did not resolve @avgupta456 in this comment with PR #28724 since (I believe) we don't quite set up the volume properly in devservices.py.

Let's revert this and I can deal with it after I deal with ClickHouse's image first.

@armenzg armenzg self-assigned this Oct 4, 2021
@armenzg armenzg added this to the Apple M1 devservices support milestone Oct 4, 2021
@armenzg armenzg added the Component: Developer Environment This covers issues related to setting up a developer's environment label Oct 4, 2021
@armenzg armenzg marked this pull request as ready for review October 4, 2021 19:42
@armenzg armenzg requested a review from a team as a code owner October 4, 2021 19:42
@armenzg armenzg merged commit 28b48ee into master Oct 4, 2021
@armenzg armenzg deleted the armenzg/ci/revert-kafka-confluent-upgrade branch October 4, 2021 20:11
armenzg added a commit that referenced this pull request Oct 6, 2021
This reverts commit 9ddd9d0.

This should have been reverted at the same time as #28672
armenzg added a commit that referenced this pull request Oct 6, 2021
This reverts commit 9ddd9d0.

This should have been reverted at the same time as #28672
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Developer Environment This covers issues related to setting up a developer's environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Kafka container restarting on Mac intel processor
2 participants