New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codecov): Add a legend for codecov line data #43201

Merged

snigdhas merged 4 commits into master from snigdha/codecov-legend

Jan 18, 2023

Member

snigdhas commented Jan 12, 2023

Add a legend for the colors of the coverage report, per these designs.

WOR-2592

github-actions bot added the Scope: Frontend label

vercel bot deployed to Preview – sentry

January 12, 2023 21:29

View deployment

vercel bot deployed to Preview – storybook

January 12, 2023 21:29

View deployment

snigdhas requested a review from a team

January 12, 2023 21:36

snigdhas marked this pull request as ready for review

January 12, 2023 21:36

snigdhas requested review from a team as code owners

January 12, 2023 21:36

scttcper reviewed

View reviewed changes

static/app/components/events/interfaces/frame/codecovLegend.tsx Outdated Show resolved Hide resolved

scttcper reviewed

View reviewed changes

static/app/icons/iconCircleFill.tsx Show resolved Hide resolved

scttcper reviewed

View reviewed changes

static/app/components/events/interfaces/frame/codecovLegend.tsx Outdated Show resolved Hide resolved

scttcper reviewed

View reviewed changes

static/app/components/events/interfaces/frame/line.tsx Outdated Show resolved Hide resolved

scttcper reviewed

View reviewed changes

static/app/components/events/interfaces/frame/codecovLegend.tsx Outdated Show resolved Hide resolved

scttcper reviewed

View reviewed changes

static/app/components/events/interfaces/frame/codecovLegend.tsx Outdated Show resolved Hide resolved

scttcper reviewed

View reviewed changes

static/app/components/events/interfaces/frame/codecovLegend.tsx Outdated Show resolved Hide resolved


          Add a legend for codecov line data

911d75b

snigdhas force-pushed the snigdha/codecov-legend branch from a66fc66 to 911d75b Compare

January 12, 2023 23:17

vercel bot deployed to Preview – storybook

January 12, 2023 23:19

View deployment

Contributor

github-actions bot commented Jan 12, 2023 •

edited

Loading

size-limit report 📦

Path	Size
src/sentry/static/sentry/dist/entrypoints/app.js	19.56 KB (-0.06% 🔽)
src/sentry/static/sentry/dist/entrypoints/sentry.css	33.02 KB (0%)

vercel bot deployed to Preview – sentry

January 12, 2023 23:20

View deployment


          Cleanup imports

5f1e16b

vercel bot deployed to Preview – sentry

January 13, 2023 00:28

View deployment

vercel bot deployed to Preview – storybook

January 13, 2023 00:30

View deployment


          Add tests

ab8c914

vercel bot deployed to Preview – sentry

January 13, 2023 18:13

View deployment

vercel bot deployed to Preview – storybook

January 13, 2023 18:14

View deployment


          Merge branch 'master' into snigdha/codecov-legend

13cc16d

vercel bot deployed to Preview – storybook

January 13, 2023 19:53

View deployment

vercel bot deployed to Preview – sentry

January 13, 2023 19:54

View deployment

armenzg requested a review from a team

January 17, 2023 20:48

scttcper approved these changes

View reviewed changes

snigdhas merged commit 1afb0d0 into master

snigdhas deleted the snigdha/codecov-legend branch

January 18, 2023 18:18

armenzg added this to the Stacktrace Codecov Integration milestone

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend