fix(backup/restore): Warn users of integrity violations during backup/restore #44705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
hubertdeng123
force-pushed
the
hubertdeng123/handle-backup-integrity-error
branch
from
a8c4a39
to
631a10e
Compare
hubertdeng123
removed
the
Scope: Frontend
hubertdeng123
commented
Feb 16, 2023
hubertdeng123
commented
Feb 16, 2023
hubertdeng123
commented
Feb 16, 2023
9 tasks
markstory
reviewed
Feb 22, 2023
hubertdeng123
changed the title
src/sentry/runner/commands/backup.py
Outdated
| # these errors come from restoring on a different version of Sentry or not restoring | ||
| # on a clean install. | ||
| except IntegrityError as e: | ||
| warningText = ">> Are you restoring from a backup of the same version of Sentry?\n>> Are you restoring onto a clean database?\n>> https://github.com/getsentry/sentry/issues/new/choose" |
There was a problem hiding this comment.
Sorry I was unclear, if we have the link we should also have the "if neither, then open an issue here:" text. 🐭
There was a problem hiding this comment.
hubertdeng123
force-pushed
the
hubertdeng123/handle-backup-integrity-error
branch
from
822129c
to
82c178b
Compare
hubertdeng123
deleted the
hubertdeng123/handle-backup-integrity-error
branch
36 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are getting this error when restoring from a backup
We should wrap the model saves in one single atomic transaction so that none of the data is saved if an error happens. On integrity error, let's warn users to use a clean db.
Also added some quick tests are backup/restore logic to make sure it doesn't error out