feat(issue-states): Add presave checks for GroupSubStatus

[snigdhas]

• Add presave checks for GroupSubStatus to ensure we don't end up with inconsistent status/substatus pairings
• Add substatuses in the code when we change the status values
• Update tests to include substatuses in test data
• Add tests to check the substatus presave validation

WOR-2973

[codecov]

Codecov Report

Merging #47420 (05b49da) into master (d3aab77) will decrease coverage by 0.49%.
The diff coverage is 88.88%.

❗ Current head 05b49da differs from pull request most recent head 28fa05a. Consider uploading reports for the commit 28fa05a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #47420      +/-   ##
==========================================
- Coverage   80.73%   80.25%   -0.49%     
==========================================
  Files        4760     4759       -1     
  Lines      201264   201328      +64     
  Branches    11626    11626              
==========================================
- Hits       162481   161566     -915     
- Misses      38525    39504     +979     
  Partials      258      258              

Impacted Files	Coverage Δ
src/sentry/api/helpers/group_index/delete.py	96.15% <ø> (ø)
src/sentry/deletions/defaults/group.py	100.00% <ø> (ø)
src/sentry/receivers/releases.py	93.63% <ø> (ø)
src/sentry/tasks/auto_resolve_issues.py	93.33% <ø> (ø)
src/sentry/models/group.py	93.22% <81.81%> (-0.39%)	⬇️
src/sentry/api/helpers/group_index/update.py	94.21% <100.00%> (+0.24%)	⬆️
src/sentry/issues/status_change.py	100.00% <100.00%> (ø)
src/sentry/models/release.py	96.98% <100.00%> (ø)
src/sentry/tasks/clear_expired_snoozes.py	100.00% <100.00%> (ø)
...c/sentry/tasks/integrations/sync_status_inbound.py	96.29% <100.00%> (+0.14%)	⬆️

... and 64 files with indirect coverage changes

[armenzg]

Thanks for all the effort on this PR! It must have not been the most fun to go through all those files.

[armenzg]

I wonder if we should use logger.exception first and then on a follow up PR make all the ValueError changes.

What do you think?

Maybe I'm paranoid.

[snigdhas]

that's a great idea - we can let it run for a week and switch to ValueError if things look safe

[armenzg]

🎉