Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(issue-states): manual transitions from and to ONGOING #47691

Merged
merged 8 commits into from
May 3, 2023
Merged

feat(issue-states): manual transitions from and to ONGOING #47691

merged 8 commits into from
May 3, 2023

Conversation

barkbarkimashark
Copy link
Contributor

@barkbarkimashark barkbarkimashark commented Apr 20, 2023 •
edited
Loading

This was mostly being handled already, we just need to explicitly set the substatus to a default when a user requests to transition to Group(status=UNRESOLVED, substatus=None)

@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Merging #47691 (3a88d53) into master (173d4a3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #47691      +/-   ##
==========================================
+ Coverage   80.90%   80.91%   +0.01%     
==========================================
  Files        4772     4776       +4     
  Lines      201774   201727      -47     
  Branches    11525    11525              
==========================================
- Hits       163239   163231       -8     
+ Misses      38280    38241      -39     
  Partials      255      255
Impacted Files Coverage Δ
src/sentry/api/helpers/group_index/update.py 94.55% <100.00%> (+0.03%) ⬆️

... and 132 files with indirect coverage changes

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 20, 2023
@barkbarkimashark barkbarkimashark force-pushed the sharky/issue-state-ongoing-to-fro branch from 37675a0 to dd9c49d Compare April 20, 2023 02:06
@barkbarkimashark barkbarkimashark changed the title test(issue-states): verify manual transitions from and to ONGOING feat(issue-states): manual transitions from and to ONGOING Apr 20, 2023
@snigdhas snigdhas added this to the Issue States and Filters milestone Apr 20, 2023
@barkbarkimashark barkbarkimashark marked this pull request as ready for review April 20, 2023 18:24
@barkbarkimashark barkbarkimashark requested a review from a team April 20, 2023 18:24
@barkbarkimashark barkbarkimashark force-pushed the sharky/issue-state-ongoing-to-fro branch from 0e0184d to 0e55560 Compare May 1, 2023 17:40
@barkbarkimashark barkbarkimashark merged commit c1b2bff into master May 3, 2023
@barkbarkimashark barkbarkimashark deleted the sharky/issue-state-ongoing-to-fro branch May 3, 2023 22:00
@snigdhas snigdhas mentioned this pull request May 8, 2023
Closed
@barkbarkimashark barkbarkimashark mentioned this pull request May 9, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wedamija wedamija wedamija approved these changes

@snigdhas snigdhas Awaiting requested review from snigdhas

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
Issue States and Filters
Development

Successfully merging this pull request may close these issues.
3 participants
@barkbarkimashark @wedamija @snigdhas