ref(escalating_issues): Improve code and typing #47822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Apr 24, 2023
| @@ -39,33 +38,33 @@ | |||
| ParsedGroupsCount = Dict[int, GroupCount] | |||
|
|
|||
|
|
|||
| def query_groups_past_counts(groups: List[Group]) -> List[GroupsCountResponse]: | |||
| def query_groups_past_counts(groups: Sequence[Group]) -> List[GroupsCountResponse]: | |||
There was a problem hiding this comment.
A best practice @asottile-sentry encouraged me to follow is to have loose typing as input and tighter typing on returns.
| all_results = [] | ||
| offset = 0 | ||
| while True: | ||
| query = _generate_query(project_ids, group_ids, offset, start_date, end_date) | ||
| request = Request(dataset=Dataset.Events.value, app_id=REFERRER, query=query) | ||
| results = raw_snql_query(request, referrer=REFERRER)["data"] | ||
| if not results: |
There was a problem hiding this comment.
This solves an N+1 perf issue Oliver noticed on the other PR.
| @@ -36,7 +36,7 @@ def handle_archived_until_escalating( | |||
| metrics.incr("group.archived_until_escalating", skip_internal=True) | |||
| for group in group_list: | |||
| remove_group_from_inbox(group, action=GroupInboxRemoveAction.IGNORED, user=acting_user) | |||
| generate_and_save_forecasts(list(group_list)) | |||
| generate_and_save_forecasts(group_list) | |||
There was a problem hiding this comment.
This is an actual bug that went unnoticed.
The PR #47820 will solve that this slipped through.
snigdhas
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are various code improvements and it improves the readability of #47626