Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(escalating-issues): Add analytic for groups added to nodestore #47954

Merged
merged 3 commits into from
Apr 26, 2023
Merged

ref(escalating-issues): Add analytic for groups added to nodestore #47954

merged 3 commits into from
Apr 26, 2023

Conversation

jangjodi
Copy link
Member

Add analytic for number of groups added to nodestore

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #47954 (76a32af) into master (bc8ab8b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 76a32af differs from pull request most recent head ad13150. Consider uploading reports for the commit ad13150 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #47954      +/-   ##
==========================================
- Coverage   80.84%   80.84%   -0.01%     
==========================================
  Files        4765     4765              
  Lines      201456   201518      +62     
  Branches    11570    11580      +10     
==========================================
+ Hits       162874   162910      +36     
- Misses      38326    38352      +26     
  Partials      256      256
Impacted Files Coverage Δ
src/sentry/tasks/weekly_escalating_forecast.py 95.23% <ø> (ø)
src/sentry/issues/analytics.py 100.00% <100.00%> (ø)
src/sentry/issues/apps.py 100.00% <100.00%> (ø)
src/sentry/issues/forecasts.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

@jangjodi jangjodi marked this pull request as ready for review April 26, 2023 15:23
armenzg
armenzg approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you @jangjodi !

@armenzg armenzg added this to the Escalating Issues V1 milestone Apr 26, 2023
@jangjodi jangjodi merged commit 82e7fe0 into master Apr 26, 2023
@jangjodi jangjodi deleted the jodi/escalating-nodestore-analytic branch April 26, 2023 17:23
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armenzg armenzg armenzg approved these changes

@NisanthanNanthakumar NisanthanNanthakumar Awaiting requested review from NisanthanNanthakumar

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
Escalating Issues V1
Development

Successfully merging this pull request may close these issues.
2 participants
@jangjodi @armenzg