Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflow): Switch weekly issues breakdown to group inbox #48047

Merged
merged 7 commits into from
May 10, 2023
Merged

feat(workflow): Switch weekly issues breakdown to group inbox #48047

merged 7 commits into from
May 10, 2023

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Apr 27, 2023 •
edited
Loading

before
image

after
image

WOR-2997
fixes #48238
fixes #48759

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Merging #48047 (ba29550) into master (64ab473) will decrease coverage by 0.01%.
The diff coverage is 78.68%.

❗ Current head ba29550 differs from pull request most recent head a96147a. Consider uploading reports for the commit a96147a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #48047      +/-   ##
==========================================
- Coverage   80.92%   80.92%   -0.01%     
==========================================
  Files        4775     4775              
  Lines      201704   201781      +77     
  Branches    11512    11513       +1     
==========================================
+ Hits       163223   163282      +59     
- Misses      38226    38244      +18     
  Partials      255      255
Impacted Files Coverage Δ
static/app/utils/requestError/sanitizePath.tsx 100.00% <ø> (ø)
...c/sentry/web/frontend/debug/debug_weekly_report.py 32.14% <8.33%> (-3.28%) ⬇️
src/sentry/tasks/weekly_reports.py 84.21% <95.83%> (+1.48%) ⬆️
src/sentry/incidents/endpoints/bases.py 63.15% <100.00%> (ø)

... and 26 files with indirect coverage changes

@scttcper scttcper requested a review from a team April 27, 2023 21:59
@scttcper scttcper marked this pull request as ready for review April 27, 2023 21:59
@scttcper scttcper requested review from a team and scefali May 2, 2023 18:36
@scttcper scttcper requested a review from armenzg May 2, 2023 21:30
@scttcper scttcper added this to the Issue States and Filters milestone May 9, 2023
snigdhas
snigdhas reviewed May 9, 2023
View reviewed changes
src/sentry/tasks/weekly_reports.py Outdated
with sentry_sdk.start_span(op="weekly_reports.organization_project_issue_summaries"):
organization_project_issue_summaries(ctx)

if has_escalating_issues:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be part of the issue states project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a different flag for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

organizations:issue-states

@scttcper scttcper merged commit 434f271 into master May 10, 2023
@scttcper scttcper deleted the scttcper/weekly-escalating branch May 10, 2023 15:47
@NisanthanNanthakumar NisanthanNanthakumar mentioned this pull request May 10, 2023
Closed
@scttcper scttcper mentioned this pull request May 18, 2023
Closed
scttcper added a commit that referenced this pull request May 19, 2023
@scttcper
feat(issue-states): Use group substatus to build weekly summary
96ceb8f 
In #48047 I used group inbox reason to add issue states to the weekly email. This turned out to be the wrong approach and we want to use the new substatus to get our issue counts.

fixes #49417
@scttcper scttcper mentioned this pull request May 19, 2023
Merged
volokluev pushed a commit that referenced this pull request May 30, 2023
@scttcper @volokluev
feat(workflow): Switch weekly issues breakdown to group inbox (#48047)
098afce
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@snigdhas snigdhas snigdhas approved these changes

@armenzg armenzg armenzg approved these changes

@scefali scefali Awaiting requested review from scefali

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
Issue States and Filters
3 participants
@scttcper @armenzg @snigdhas