Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(starfish): Compare span samples to p50 baseline in table column #48959

Merged
merged 2 commits into from
May 15, 2023
Merged

feat(starfish): Compare span samples to p50 baseline in table column #48959

merged 2 commits into from
May 15, 2023

Conversation

0Calories
Copy link
Member

@0Calories 0Calories commented May 11, 2023 •
edited
Loading

On the span samples table, compares individual sample span durations to the p50 baseline

image

@0Calories 0Calories self-assigned this May 11, 2023
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 11, 2023
@0Calories 0Calories marked this pull request as ready for review May 11, 2023 20:03
@0Calories 0Calories requested a review from a team May 11, 2023 20:03
DominikB2014
DominikB2014 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! Are we also going to be adding sorting on this table?

@0Calories
Copy link
Member Author

No sorting for now, none of the columns appear to be sortable yet so we can add them all later

@0Calories 0Calories merged commit ff94182 into master May 15, 2023
@0Calories 0Calories deleted the feat/db-samples-list branch May 15, 2023 16:15
volokluev pushed a commit that referenced this pull request May 30, 2023
@0Calories @volokluev
feat(starfish): Compare span samples to p50 baseline in table column (#…
8a9d107 
…48959)
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DominikB2014 DominikB2014 DominikB2014 approved these changes

Assignees

@0Calories 0Calories

Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0Calories @DominikB2014