Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(sdk): Filter out 4xx request errors in beforeSend #49045

Merged
merged 2 commits into from
May 12, 2023
Merged

ref(sdk): Filter out 4xx request errors in beforeSend #49045

merged 2 commits into from
May 12, 2023

Conversation

lobsterkatie
Copy link
Member

This stops the SDK from sending 401, 403, and 404 errors generated by our frontend API client to Sentry. In the long run, we want to improve the way we handle request errors in general, but for the moment, this should quiet a bit of noise in our JS project.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 12, 2023
@lobsterkatie lobsterkatie marked this pull request as ready for review May 12, 2023 21:05
@lobsterkatie lobsterkatie merged commit e3ae5d8 into master May 12, 2023
@lobsterkatie lobsterkatie deleted the kmclb-filter-out-4xx-request-errors-in-beforeSend branch May 12, 2023 21:29
@scttcper scttcper added this to the JS Project Cleanup milestone May 15, 2023
@lobsterkatie lobsterkatie mentioned this pull request May 22, 2023
Merged
lobsterkatie added a commit that referenced this pull request May 22, 2023
@lobsterkatie
ref(js): Filter out request errors when used as cause (#49541)
adcc680 
This builds upon #49045 and #49415 (which filter request errors based on their status code) and #49385 (which includes request errors as `cause` when appropriate) to filter out the same types of errors when they appear as the main error's cause.
volokluev pushed a commit that referenced this pull request May 30, 2023
@lobsterkatie @volokluev
ref(sdk): Filter out 4xx request errors in beforeSend (#49045)
80519c0 
This stops the SDK from sending 401, 403, and 404 errors generated by our frontend API client to Sentry. In the long run, we want to improve the way we handle request errors in general, but for the moment, this should quiet a bit of noise in our JS project.
volokluev pushed a commit that referenced this pull request May 30, 2023
@lobsterkatie @volokluev
ref(js): Filter out request errors when used as cause (#49541)
f6a58fd 
This builds upon #49045 and #49415 (which filter request errors based on their status code) and #49385 (which includes request errors as `cause` when appropriate) to filter out the same types of errors when they appear as the main error's cause.
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
JS Project Cleanup
Development

Successfully merging this pull request may close these issues.
2 participants
@lobsterkatie @scttcper