ref(api): Rename handleXhrErrorResponse to getXhrErrorResponseHandler
#49100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
approved these changes
May 15, 2023
lobsterkatie
added a commit
that referenced
this pull request
May 16, 2023
…ResponseHandler` (#49154) This recreates the `handleXhrErrorResponse` helper renamed to `getXhrErrorResponseHandler` in #49100 as a two-argument wrapper for `getXhrErrorResponseHandler`. In that wrapper it calls `getXhrErrorResponseHandler` to get a handler and then applies that handler, so that it can finally live up to its name and actually do the handling of error responses. This also switches all uses of `getXhrErrorResponseHandler` to instead use the new `handleXhrErrorResponse`.
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
…ler` (#49100) This renames `handleXhrErrorResponse` a) so that its name better reflects what it does, and b) as a preliminary step in changing how such responses are handled in a way that's backwards-compatible with `getsentry`. (Since it's a default export, changing the name in the file where it's defined doesn't affect `getsentry`, but it does make it so that when a similar change is made in `getsentry`, all of the names match.)
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
…ResponseHandler` (#49154) This recreates the `handleXhrErrorResponse` helper renamed to `getXhrErrorResponseHandler` in #49100 as a two-argument wrapper for `getXhrErrorResponseHandler`. In that wrapper it calls `getXhrErrorResponseHandler` to get a handler and then applies that handler, so that it can finally live up to its name and actually do the handling of error responses. This also switches all uses of `getXhrErrorResponseHandler` to instead use the new `handleXhrErrorResponse`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
handleXhrErrorResponsea) so that its name better reflects what it does, and b) as a preliminary step in changing how such responses are handled in a way that's backwards-compatible withgetsentry. (Since it's a default export, changing the name in the file where it's defined doesn't affectgetsentry, but it does make it so that when a similar change is made ingetsentry, all of the names match.)