Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Spotlight #61355

Merged
merged 18 commits into from
Dec 11, 2023
Merged

feat: Add Spotlight #61355

merged 18 commits into from
Dec 11, 2023

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Dec 7, 2023

Follow-up: #60523

@HazAT HazAT requested review from a team as code owners December 7, 2023 15:30
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

billyvg
billyvg reviewed Dec 7, 2023
View reviewed changes
src/sentry/utils/sdk.py
@@ -458,6 +458,7 @@ def flush(
ThreadingIntegration(propagate_hub=True),
OpenAiIntegration(capture_prompts=True),
],
spotlight=settings.IS_DEV,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this get used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean Spotlight?
Only in dev mode this option should be True

@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Merging #61355 (25d7cf2) into master (7d8436d) will decrease coverage by 2.02%.
The diff coverage is n/a.

❗ Current head 25d7cf2 differs from pull request most recent head 8978da7. Consider uploading reports for the commit 8978da7 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #61355      +/-   ##
==========================================
- Coverage   83.10%   81.09%   -2.02%     
==========================================
  Files        5546     5195     -351     
  Lines      237303   228310    -8993     
  Branches    38257    38285      +28     
==========================================
- Hits       197209   185145   -12064     
+ Misses      39810    37550    -2260     
- Partials      284     5615    +5331
Files Coverage Δ
src/sentry/conf/server.py 89.47% <ø> (-1.66%) ⬇️
src/sentry/utils/sdk.py 71.17% <ø> (-9.04%) ⬇️
static/app/bootstrap/initializeSdk.tsx 0.00% <ø> (ø)

... and 1887 files with indirect coverage changes

@HazAT
Copy link
Member Author

HazAT commented Dec 7, 2023

Need to figure out this:
#60523 (comment)

when I run locally in the branch:
yarn build-production
and
yarn tsc -p config/tsconfig.build.json
both succeed

@billyvg
Copy link
Member

billyvg commented Dec 7, 2023

@HazAT it needs to be a dep, not devDep

@HazAT
Copy link
Member Author

HazAT commented Dec 7, 2023

@HazAT it needs to be a dep, not devDep

Done, thx

billyvg
billyvg reviewed Dec 7, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
billyvg
billyvg approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we'd not have the webpack plugin as a dep, but I think that'd require some webpack config refactoring.

@HazAT HazAT merged commit 6c235b0 into master Dec 11, 2023
52 checks passed
@HazAT HazAT deleted the feat/spotlight branch December 11, 2023 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HazAT @billyvg