fix(starfish): Obey utc URL parameter
#61963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This component always obeys the start and end time of the current selection, so it should obey the UTC parameter, too.
github-actions
bot
added
the
Scope: Frontend
AbhiPrasad
approved these changes
Dec 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the hacks of early Starfish. Back then, we manually hard-coded
utc={false}. We don't need to do that anymore. The StarfishChartcomponent auto-obeys the start and end! This is handy because it's also a good place to always obey theutcparameter.Changes
utcURL parameter inChart