Use svg-sprite-loader #6764
Merged
Use svg-sprite-loader #6764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sentry into use_webpack_svg_sprite_loader
Generated by 🚫 danger |
dcramer
approved these changes
Dec 14, 2017
|
@dcramer thanks lol. Did you catch the inline svg component? Wanna make sure it didn't get lost in all the svg changes. |
|
also to anyone who cares: i'm gonna finish changing over all these svgs in another pull to help simplify the process of releasing this thing |
…ested this in production and can confirm is works
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tested and works on ie, chrome, and firefox. svg-sprite-loader takes advantage of
useto create an svg sprite that get's webpacked in without the transpiling you get with other loaders.The setup is actually very simple and makes it much easier to export and import things between sketch and the app.
I included the svgo loader as an added free bonus 🌈 🎁 🦄
To keep things low-risk, this pull only changes two icons:
icon-copyandicon-refresh, which are both used inshareIssue.jsxand are super easy to test.A follow-up pull will change the other 10 or so svg icons in the codebase.