Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(delayed rules): Don't use a decorator, call add_handler instead #70689

Merged
merged 4 commits into from
May 13, 2024

Conversation

ceorourke
Copy link
Member

@ceorourke ceorourke commented May 10, 2024

It doesn't seem like any of the delayed processing is being called since it's not imported by anything, so this PR changes the registry pattern a bit so that it does.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 10, 2024
src/sentry/tasks/post_process.py Outdated Show resolved Hide resolved
src/sentry/tasks/post_process.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.03%. Comparing base (8c9fbbd) to head (5d0f9b7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #70689       +/-   ##
===========================================
+ Coverage   50.46%   80.03%   +29.57%     
===========================================
  Files        6469     6506       +37     
  Lines      289328   290760     +1432     
  Branches    49888    50103      +215     
===========================================
+ Hits       146003   232713    +86710     
+ Misses     142892    57613    -85279     
- Partials      433      434        +1     
Files Coverage Δ
src/sentry/buffer/redis.py 92.05% <100.00%> (+64.33%) ⬆️
src/sentry/rules/processing/delayed_processing.py 93.15% <100.00%> (+70.87%) ⬆️
src/sentry/tasks/post_process.py 92.23% <100.00%> (+78.48%) ⬆️

... and 2104 files with indirect coverage changes

Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🤞

@ceorourke ceorourke marked this pull request as ready for review May 13, 2024 16:52
@ceorourke ceorourke requested a review from a team as a code owner May 13, 2024 16:52
@ceorourke ceorourke merged commit d3fd56a into master May 13, 2024
50 checks passed
@ceorourke ceorourke deleted the ceorourke/delayed-rules-dont-decorate-registry branch May 13, 2024 17:02
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants