ref(mqb): Remove the flag for defaulting tags

[wmak]

• This flag has been GA'ed for a while now so lets just default it now since we should always do this

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (5aeaf13) to head (a979222).
Report is 1647 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #71697      +/-   ##
==========================================
- Coverage   78.01%   77.70%   -0.32%     
==========================================
  Files        6632     6631       -1     
  Lines      296035   295786     -249     
  Branches    50986    50934      -52     
==========================================
- Hits       230957   229834    -1123     
- Misses      58794    59618     +824     
- Partials     6284     6334      +50     

Files	Coverage Δ
src/sentry/features/temporary.py	100.00% <ø> (ø)
src/sentry/search/events/builder/metrics.py	45.86% <100.00%> (-42.66%)	⬇️
src/sentry/search/events/builder/spans_metrics.py	100.00% <100.00%> (ø)

... and 176 files with indirect coverage changes

[mjq]

👍

[getsantry]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[Zylphrex]

Nit: check the override cases first for better legibility and remove the redundant len > 0 check

Suggested change

	(len(self.valid_tags) > 0 and value in self.valid_tags)
	or len(self.valid_tags) == 0
	or self.use_on_demand
	len(self.valid_tags) == 0
	or self.use_on_demand
	or value in self.valid_tags

[getsantry]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀