Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay-new-trace) Fetching replay trace data in batches. #72639

Merged
merged 6 commits into from
Jun 13, 2024
Merged

feat(replay-new-trace) Fetching replay trace data in batches. #72639

merged 6 commits into from
Jun 13, 2024

Conversation

Abdkhan14
Copy link
Contributor

@Abdkhan14 Abdkhan14 commented Jun 12, 2024 •
edited
Loading

A replay can have multiple traces and also need to know the metadata for each trace. We have a limit on the number of requests we can make at a time.This pr fetches the replay trace data in batches of 3 and adds timestamp param toevents-traceendpoint requests.

@Abdkhan14 Abdkhan14 requested review from wmak and JonasBa June 12, 2024 19:04
@Abdkhan14 Abdkhan14 requested review from a team as code owners June 12, 2024 19:04
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 20.9kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 27.94MB 20.9kB ⬇️

@Abdkhan14 Abdkhan14 enabled auto-merge (squash) June 13, 2024 15:17
@Abdkhan14 Abdkhan14 merged commit cd6efea into master Jun 13, 2024
40 of 41 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/replay-trace-data-fetching branch June 13, 2024 15:21
@JonasBa JonasBa added the Trigger: Revert add to a merged PR to revert it (skips CI) label Jun 14, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: ba9b082

getsentry-bot added a commit that referenced this pull request Jun 14, 2024
@getsentry-bot @JonasBa
Revert "feat(replay-new-trace) Fetching replay trace data in batches. (…
ba9b082 
…#72639)"

This reverts commit cd6efea.

Co-authored-by: JonasBa <9317857+JonasBa@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JonasBa JonasBa JonasBa approved these changes

@wmak wmak Awaiting requested review from wmak

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abdkhan14 @getsentry-bot @JonasBa