Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(similarity): cohort backfill pr adjustments #73126

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

JoshFerge
Copy link
Member

follow ups from #73075

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (21e7c12) to head (87df83f).

Current head 87df83f differs from pull request most recent head 7c60f63

Please upload reports for the commit 7c60f63 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73126      +/-   ##
==========================================
- Coverage   77.99%   77.98%   -0.02%     
==========================================
  Files        6625     6623       -2     
  Lines      295652   295563      -89     
  Branches    50927    50904      -23     
==========================================
- Hits       230598   230486     -112     
- Misses      58775    58801      +26     
+ Partials     6279     6276       -3     
Files Coverage Δ
...ping/backfill_seer_grouping_records_for_project.py 83.09% <100.00%> (ø)
src/sentry/tasks/embeddings_grouping/utils.py 91.07% <100.00%> (ø)

... and 152 files with indirect coverage changes

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for following up on this!

@JoshFerge JoshFerge enabled auto-merge (squash) June 21, 2024 21:48
@JoshFerge JoshFerge merged commit 9d03ade into master Jun 21, 2024
48 checks passed
@JoshFerge JoshFerge deleted the jferg/backfill-feedback-pr branch June 21, 2024 23:28
priscilawebdev pushed a commit that referenced this pull request Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants