Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(similarity): in backfill lower time bounds #73345

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

JoshFerge
Copy link
Member

lower time bounds to 1 minute, as we'll scan less data, and i think this should be plenty of range for it to find the last event sent.

@JoshFerge JoshFerge requested a review from a team June 25, 2024 23:15
Copy link

sentry-io bot commented Jun 25, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/tasks/embeddings_grouping/utils.py

Function Unhandled Issue
get_data_from_snuba RateLimitExceeded: Query on could not be run due to allocation policies, details: {'CrossOrgQueryAllocationPolicy': ... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (1a142ab) to head (b36db18).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73345      +/-   ##
==========================================
- Coverage   78.01%   78.01%   -0.01%     
==========================================
  Files        6632     6632              
  Lines      296126   296126              
  Branches    50999    50999              
==========================================
- Hits       231030   231024       -6     
- Misses      58813    58815       +2     
- Partials     6283     6287       +4     
Files Coverage Δ
src/sentry/tasks/embeddings_grouping/utils.py 91.07% <ø> (ø)

... and 3 files with indirect coverage changes

@iadityagupta19
Copy link

lower time bounds to 1 minute, as we'll scan less data, and i think this should be plenty of range for it to find the last event sent.

@JoshFerge JoshFerge merged commit 9fc23cc into master Jul 1, 2024
50 checks passed
@JoshFerge JoshFerge deleted the jferg/snuba-time branch July 1, 2024 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants