Automatically refresh expired container credentials #754
Conversation
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
- Coverage 73.26% 73.21% -0.05%
==========================================
Files 49 49
Lines 10831 10838 +7
==========================================
Hits 7935 7935
- Misses 2896 2903 +7
Continue to review full report at Codecov.
|
| let container_provider = rusoto_credential::ContainerProvider::new(); | ||
| let provider = match rusoto_credential::AutoRefreshingProvider::new(container_provider) { | ||
| Ok(provider) => provider, | ||
| Err(err) => panic!("Unable to instantiate rusoto_credential::AutoRefreshingProvider: {:?}", err), |
There was a problem hiding this comment.
As source configs are being fed into symbolicator with each request, we should avoid panic-ing as much as possible. I haven’t looked at the docs to figure out the exact failure conditions for this Result, it might as well be an extreme edge-case condition in which case it might as well be okay to unwrap.
There was a problem hiding this comment.
Looking at the source of rusoto_credential::AutoRefreshingProvider::new, I don't even understand how it can return CredentialsError?
So far, testing by @mk4437 suggests this patch addresses the S3 errors [#728] we are seeing. Happy to tweak this patch further as needed.