Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit ANSI escape codes with auto=false or simplified logging formats #755

Merged

Conversation

josb
Copy link
Contributor

@josb josb commented Apr 10, 2022

Fixes [#753].

@josb josb requested a review from a team April 10, 2022 19:11
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2022

Codecov Report

Merging #755 (7350430) into master (cd2a762) will increase coverage by 0.09%.
The diff coverage is 55.04%.

❗ Current head 7350430 differs from pull request most recent head d2a0a38. Consider uploading reports for the commit d2a0a38 to get more accurate results

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   73.21%   73.30%   +0.09%     
==========================================
  Files          48       49       +1     
  Lines       10835    10831       -4     
==========================================
+ Hits         7933     7940       +7     
+ Misses       2902     2891      -11     
Impacted Files Coverage Δ
...rates/symbolicator/src/services/download/sentry.rs 22.11% <0.00%> (-0.11%) ⬇️
crates/symbolicator/src/utils/paths.rs 74.95% <40.00%> (-0.40%) ⬇️
crates/symbolicator/src/sources.rs 88.74% <50.00%> (-0.26%) ⬇️
...tor/src/services/symbolication/process_minidump.rs 55.81% <55.81%> (ø)
...tes/symbolicator/src/services/symbolication/mod.rs 83.73% <100.00%> (+12.38%) ⬆️
...icator/src/services/symbolication/module_lookup.rs 93.43% <0.00%> (+0.31%) ⬆️
...es/symbolicator/src/services/download/locations.rs 81.08% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2a762...d2a0a38. Read the comment docs.

@josb
Copy link
Contributor Author

josb commented Apr 11, 2022

Would you like me to add a changelog entry for this?

@relaxolotl
Copy link
Contributor

@josb if you don't mind doing so, that'd be great. It looks like dangerjs is struggling a little right now, but the check should pass once you add in a changelog entry. Feel free to add this into CHANGELOG.md as a fix under the unreleased section - there should be other existing entries to reference if you need any guidance on what one should look like.

If you could do the same for your other PR (#754) that'd also be much appreciated.

@josb
Copy link
Contributor Author

josb commented Apr 11, 2022

Added CHANGELOG.md entry.

@relaxolotl relaxolotl merged commit ad8f261 into getsentry:master Apr 11, 2022
@josb
Copy link
Contributor Author

josb commented Apr 11, 2022

Thanks, @relaxolotl !

@relaxolotl
Copy link
Contributor

I'll leave #754 up to @Swatinem since he's already taking care of it 👍

@josb
Copy link
Contributor Author

josb commented Apr 11, 2022

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants