-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added version to docker tag #542 #607
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #607 +/- ##
===========================================
+ Coverage 37.11% 37.13% +0.02%
===========================================
Files 21 21
Lines 2891 2892 +1
===========================================
+ Hits 1073 1074 +1
Misses 1724 1724
Partials 94 94
Continue to review full report at Codecov.
|
16c90d4
to
b113ebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @eddiewebb!
First thing, can you change this to be a PR against mozilla:develop
rather than the master
branch?
Second, I'm not a fan of using a semvar tool as it feels a bit heavy weight + I don't like pulling in some random code and running it. Can this be replaced with bash commands?
This eliminates use of 3rd party tool but greatly simplifies supported versions. MAJOR.MINOR.PTACH Minor & Patch may be omitted ("v3", "v3.2", "v3.2.1")
This change accesses the environment variable CIRCLE_TAG to address #542
Changes:
Options:
I ran in my own circle spae to test tagging. I obviously dont have your docker creds, so the push fails, but the tagging works.
Run:
Output